Tidy up quota configure tests, remove pidl from autogen.sh

Andrew Bartlett abartlet at samba.org
Mon Sep 3 00:27:59 MDT 2012


On Sun, 2012-09-02 at 23:22 +0200, Björn Jacke wrote:
> The branch, master has been updated
>        via  05f9829 waf: add new quota header checks and sysquota_4B source file
>        via  9dd0e16 s3: remove some duplicate quota code
>        via  af5dcaa s3: adopt the new sysquotas_4B support for BSD
>       from  d392485 s3: add sysquotas_4B support
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master

Thanks for merging those patches, it is really good to get the BSDs into
sysquotas, and away from the old quota code. 

Given you have dived into the quota code, I'm wondering if you can help
review some more patches I have for this area?  

The patch series I have in my quota-configure-2 branch removed the
building of our quota code at configure time, instead relying on the
configure tests to determine if quotas are supported.  This is required
so that way can then port the configure tests into waf, where we don't
have (and don't want) the pre-compilation of IDL before configure. 

Porting these tests into waf will go a long way to fixing this RC bug:

Because we don't want to break the default build on a platform that
hasn't got sysquotas support, the old quota code is now only available
if you specify --with-quotas=yes.  

I've also included patches to try and reduce the number of special case
platforms in quotas.c.  These are in decreasing order of priority - I
have only compile tested Linux and FreeBSD.  

Finally, because we no longer rely on PIDL compiled files at configure
time, I've removed running perl during autogen.sh.  This simplifies
things by removing what was essentially another duplicate build system,
and will also make my work for creating an autoconf-compatible tarball a
little easier. 

I have verified that the config.h does not change when this is removed. 



I've CC'ed you for two reasons:  The first is that with this patch,
FreeBSD now gets quota support by default, which it didn't in the past
(even with the patches Björn merged).  I'm hoping you might be able to
help me test this (I've only done compile and config.h comparison
testing so far).  The second reason is that you made the original change
to run perl in ./autogen.sh back in 2011, because of the quota code
relying on pidl.


These are the changes for the quota code that I discussed with you a
month or two ago, but didn't get to finishing at that time. 

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

More information about the samba-technical mailing list