Samba 4 RC4 fails to ./configure on FreeBSD

[Andriy Syrovenko]

Hi,

S4 RC4 fails to ./configure on FreeBSD. I've tried both officially released
tarball and git- both with the same result. I've checked for the recent
changes, and it seems like the problem is due to the following commit:

commit 5f6433e034022b033a31733b81cfdaacdd3afb9d
Author: Stefan Metzmacher <metze at samba.org>
Date:   Mon Oct 8 11:18:03 2012 +0200

Error details follow:

Checking correct behavior of strtoll                              :
Traceback (most recent call last):
  File "./buildtools/bin/waf", line 76, in <module>
    Scripting.prepare(t, cwd, VERSION, wafdir)
  File "/usr/home/andrew/SambaDev/samba/buildtools/wafadmin/Scripting.py",
line 145, in prepare
    prepare_impl(t, cwd, ver, wafdir)
  File "/usr/home/andrew/SambaDev/samba/buildtools/wafadmin/Scripting.py",
line 135, in prepare_impl
    main()
  File "/usr/home/andrew/SambaDev/samba/wscript", line 281, in main
    wildcard_main(wildcard_cmd)
  File "./buildtools/wafsamba/samba_wildcard.py", line 110, in wildcard_main
    fun(ctx)
  File "/usr/home/andrew/SambaDev/samba/buildtools/wafadmin/Scripting.py",
line 241, in configure
    conf.sub_config([''])
  File "/usr/home/andrew/SambaDev/samba/buildtools/wafadmin/Configure.py",
line 237, in sub_config
    self.recurse(k, name='configure')
  File "/usr/home/andrew/SambaDev/samba/buildtools/wafadmin/Utils.py", line
634, in recurse
    f(self)
  File "/usr/home/andrew/SambaDev/samba/wscript", line 83, in configure
    conf.RECURSE('lib/replace')
  File "./buildtools/wafsamba/samba_utils.py", line 462, in RECURSE
    return ctx.sub_config(relpath)
  File "/usr/home/andrew/SambaDev/samba/buildtools/wafadmin/Configure.py",
line 237, in sub_config
    self.recurse(k, name='configure')
  File "/usr/home/andrew/SambaDev/samba/buildtools/wafadmin/Utils.py", line
634, in recurse
    f(self)
  File "./buildtools/wafsamba/samba_utils.py", line 48, in runonce_wrapper
    ret = function(*args)
  File "/usr/home/andrew/SambaDev/samba/lib/replace/wscript", line 212, in
configure
    define = 'HAVE_BSD_STRTOLL',
  File "./buildtools/wafsamba/samba_autoconf.py", line 413, in CHECK_CODE
    conf.COMPOUND_END(conf.env[define])
  File "./buildtools/wafsamba/samba_autoconf.py", line 70, in COMPOUND_END
    p(result)
  File "/usr/home/andrew/SambaDev/samba/buildtools/wafadmin/Configure.py",
line 299, in check_message_2
    self.log.write(sr)
TypeError: expected a character buffer object

Best regards,
Andriy.