ldb: Change ltdb_unpack_data to take an ldb_context

[Andrew Bartlett]

On Tue, 2012-10-30 at 20:59 -0400, simo wrote:
> On Tue, 2012-10-30 at 23:57 +0100, Andrew Bartlett wrote:
> > commit cc6d0decc7980028293168aee267e7610752fc80
> > Author: Andrew Bartlett <abartlet at samba.org>
> > Date:   Tue Oct 30 10:21:42 2012 +1100
> > 
> >     ldb: Change ltdb_unpack_data to take an ldb_context
> >     
> >     It always de-references the module to find the ldb anyway.
> >     
> >     Andrew Bartlett 
> 
> Andrew,
> why are you messing over with these interface conventions ?
> 
> I see no rationale for this change, can you please revert and learn a
> bit about consistent and predictable interfaces ?

This interface is private to the ldb_tdb backend, but is used by ldbdump
to recover badly damaged ldb files.  It was much easier to change this
than to fake up a struct ldb_module only to de-reference it again to get
at the ldb_context. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org