[PATCH 0/3] Revert patchset that violates all ldb layering

[Simo Sorce]

This patchset compeltely violates all ldb layering, by exposing internal
module functions to a tool.
The proper way of engineering this is to expose a proper libldb level function
for tools to use and then build an ldbdump tool on top of it.

This kind of layering violation must stop in samba code.

Simo Sorce (3):
  Revert "ldb: Add ldbdump, based on tdbdump"
  Revert "ldb: Remove no-longer-existing ltdb_unpack_data_free from
    ldb_tdb.h"
  Revert "ldb: Change ltdb_unpack_data to take an ldb_context"

 lib/ldb/ldb_tdb/ldb_index.c  |   2 +-
 lib/ldb/ldb_tdb/ldb_pack.c   |   4 +-
 lib/ldb/ldb_tdb/ldb_search.c |   6 +-
 lib/ldb/ldb_tdb/ldb_tdb.c    |   2 +-
 lib/ldb/ldb_tdb/ldb_tdb.h    |   4 +-
 lib/ldb/tools/ldbdump.c      | 219 -------------------------------------------
 lib/ldb/wscript              |   4 -
 7 files changed, 11 insertions(+), 230 deletions(-)
 delete mode 100644 lib/ldb/tools/ldbdump.c

-- 
1.7.11.7