[PATCH 0/1] Revert gratuitous change
idra at samba.org
Tue Oct 30 20:35:54 MDT 2012
On Tue, 2012-10-30 at 22:31 -0400, Simo Sorce wrote:
> This change was completely gratuitous and unnecessary.
> Every single function here takes a a module structure as a context.
> Changing this convention for a single function makes no sense, it
> just makes the interface irregular with absolutely no gain whatsoever.
> Simo Sorce (1):
> Revert "ldb: Change ltdb_unpack_data to take an ldb_context"
> lib/ldb/ldb_tdb/ldb_index.c | 2 +-
> lib/ldb/ldb_tdb/ldb_pack.c | 4 +++-
> lib/ldb/ldb_tdb/ldb_search.c | 6 +++---
> lib/ldb/ldb_tdb/ldb_tdb.c | 2 +-
> lib/ldb/ldb_tdb/ldb_tdb.h | 2 +-
> 5 files changed, 9 insertions(+), 7 deletions(-)
I just realizwed the damage has been compounded by exposing a module
private interface to a separate utility.
I will send a patch that fixes that too.
This is exactly the kind of crap for which reviews would *really* be
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
More information about the samba-technical