s3-vfs: split @GMT token filter code into a common .c

Jeremy Allison jra at samba.org
Tue Oct 30 10:25:00 MDT 2012

On Tue, Oct 30, 2012 at 10:18:00AM +0100, Michael Adam wrote:
> What is the difference, symbol-wise, between two modules that
> include a given .c file and hence create just a single .o file
> each and two modules that link the same additional .o file to
> their own .o files? Is it that the symbols of the shared extra
> .c/.o file would have to be published? If this is the problem,
> I understand that the inclusion might solve the issue when we
> create shared objects for the two modules. But what if we
> link the two .o files directly (and hence) statically into (e.g.) smbd,
> wouldn't the private symbols collide in smbd as well?
> I think (and may be mistakten) that the original motivation of
> using the include for the vfs_acl_common.c file was the
> define "ACL_MODULE_NAME" that was done in the vfs_acl_tdb and
> vfs_acl_xattr modules and used in the common file for the module
> parametric conf options. To me this appears simply as lazyness. ;-)
> Jeremy, I apologize in advance if I am not doing you justice here...

No, it's a fair cop :-). It was the easiest way to make
it work in the link, so I did that. I don't like including .c
files either :-).

If you can work out a more elegant way to do this I will
review and push your patch :-).



More information about the samba-technical mailing list