[PATCHSET] fix some debugs in lib/param/

[Michael Adam]

On 2012-10-29 at 22:08 +0100, Andreas Schneider wrote:
> On Monday 29 October 2012 16:34:27 simo wrote:
> > On Mon, 2012-10-29 at 21:16 +0100, Andreas Schneider wrote:
> > > On Monday 29 October 2012 16:04:18 Michael Adam wrote:
> > > > Hi Ira,
> > > > 
> > > > Correct way (according to me) is this:
> > > > 
> > > > 1) apply the patchset to a local checkout of master
> > > > 
> > > >    set to "origin/master"
> > > >    
> > > >    in this case:
> > > >     - store the attachment
> > > >     - do "git am <file>" on the mbox file
> > > 
> > > Why don't we just use sign off. git already provides options to
> > > automatically add it to all patches, even in a mbox with several patches.
> > 
> > Signed-off means you actually are on of the author of the patch.
> > A reviewer is generally not.
> 
> I don't really see a problem with using it like others too.
> 
> https://groups.google.com/forum/?fromgroups=#!topic/fa.linux.kernel/TLJIJVA-I6o

Er, well, that thread is 8 years old.

A couple of days ago, we discussed this on the mailing list and
on IRC. Here is my mail summarizing it:

https://lists.samba.org/archive/samba-technical/2012-October/088086.html

This is the current Linux kernel doc:

http://www.kernel.org/doc/Documentation/SubmittingPatches

To start pinning things down, I extended the wiki page on code review:

https://wiki.samba.org/index.php/CodeReview

Cheers - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121030/fcde86b1/attachment.pgp>