[PATCHSET] fix some debugs in lib/param/

simo idra at samba.org
Mon Oct 29 14:34:27 MDT 2012


On Mon, 2012-10-29 at 21:16 +0100, Andreas Schneider wrote:
> On Monday 29 October 2012 16:04:18 Michael Adam wrote:
> > Hi Ira,
> > 
> > Correct way (according to me) is this:
> > 
> > 1) apply the patchset to a local checkout of master
> >    set to "origin/master"
> >    in this case:
> >     - store the attachment
> >     - do "git am <file>" on the mbox file
> 
> Why don't we just use sign off. git already provides options to automatically 
> add it to all patches, even in a mbox with several patches.

Signed-off means you actually are on of the author of the patch.
A reviewer is generally not.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>



More information about the samba-technical mailing list