[PATCHSET] fix some debugs in lib/param/
ira at samba.org
Mon Oct 29 09:33:55 MDT 2012
The patch has been pushed to autobuild.
On Mon, Oct 29, 2012 at 11:04 AM, Michael Adam <obnox at samba.org> wrote:
> Hi Ira,
> Correct way (according to me) is this:
> 1) apply the patchset to a local checkout of master
> set to "origin/master"
> in this case:
> - store the attachment
> - do "git am <file>" on the mbox file
> 2) review the patches, do all the builds/tests with them that you
> deem reasonable
> 3) if You are ok with theadd "Reviewed-by: ...." to each commit of the patchset,
> e.g. by doing "git rebase -i origin/master"
> (else roundtrip via author)
> 4) push to autobuild
> Cheers - Michael
> On 2012-10-29 at 10:57 -0400, Ira Cooper wrote:
>> Patch is good. What is the correct way to push this. I know it
>> sounds "noobish" but I'd rather get it right. ;)
>> On Mon, Oct 29, 2012 at 10:21 AM, Michael Adam <obnox at samba.org> wrote:
>> > ENOATTACHMENT
>> > On 2012-10-29 at 15:21 +0100, Michael Adam wrote:
>> >> Hi,
>> >> this patchset fixes a couple of debug statements in
>> >> lib/param/loadparm.c
>> >> This is also a test what happens with an mbox-style
>> >> patchset (produced with "git format-patch --stdout")
>> >> in our patchwork server.
>> >> Cheers - Michael
More information about the samba-technical