[PATCHSET] fix some debugs in lib/param/

[Michael Adam]

ENOATTACHMENT

On 2012-10-29 at 15:21 +0100, Michael Adam wrote:
> Hi,
> 
> this patchset fixes a couple of debug statements in
> lib/param/loadparm.c
> 
> This is also a test what happens with an mbox-style
> patchset (produced with "git format-patch --stdout")
> in our patchwork server.
> 
> Cheers - Michael
-------------- next part --------------
From 3825d7df9cde0c7306beebac3b36f2f157d46ac8 Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Mon, 29 Oct 2012 13:44:54 +0100
Subject: [PATCH 1/3] lib/param: fix function name (lpcfg_file_list_changed)
 in a debug message

Signed-off-by: Michael Adam <obnox at samba.org>
---
 lib/param/loadparm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c
index b2e4218..97e2adc 100644
--- a/lib/param/loadparm.c
+++ b/lib/param/loadparm.c
@@ -1076,7 +1076,7 @@ static void add_to_file_list(struct loadparm_context *lp_ctx,
 bool lpcfg_file_list_changed(struct loadparm_context *lp_ctx)
 {
 	struct file_lists *f;
-	DEBUG(6, ("lp_file_list_changed()\n"));
+	DEBUG(6, ("lpcfg_file_list_changed()\n"));
 
 	for (f = lp_ctx->file_lists; f != NULL; f = f->next) {
 		char *n2;
-- 
1.7.9.5


From 215df96756a1ba1a82ece0d848ac114f79189af6 Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Mon, 29 Oct 2012 14:52:50 +0100
Subject: [PATCH 2/3] lib/param: fix function name (set_variable) in debug
 statements

Signed-off-by: Michael Adam <obnox at samba.org>
---
 lib/param/loadparm.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c
index 97e2adc..66ff9a5 100644
--- a/lib/param/loadparm.c
+++ b/lib/param/loadparm.c
@@ -1300,7 +1300,7 @@ static bool set_variable(TALLOC_CTX *mem_ctx, int parmnum, void *parm_ptr,
 		case P_BOOL: {
 			bool b;
 			if (!set_boolean(pszParmValue, &b)) {
-				DEBUG(0,("lp_do_parameter(%s): value is not boolean!\n", pszParmValue));
+				DEBUG(0,("set_variable(%s): value is not boolean!\n", pszParmValue));
 				return false;
 			}
 			*(bool *)parm_ptr = b;
@@ -1310,7 +1310,7 @@ static bool set_variable(TALLOC_CTX *mem_ctx, int parmnum, void *parm_ptr,
 		case P_BOOLREV: {
 			bool b;
 			if (!set_boolean(pszParmValue, &b)) {
-				DEBUG(0,("lp_do_parameter(%s): value is not boolean!\n", pszParmValue));
+				DEBUG(0,("set_variable(%s): value is not boolean!\n", pszParmValue));
 				return false;
 			}
 			*(bool *)parm_ptr = !b;
@@ -1339,8 +1339,8 @@ static bool set_variable(TALLOC_CTX *mem_ctx, int parmnum, void *parm_ptr,
 				}
 			}
 
-			DEBUG(0,("lp_do_parameter(%s): value is not "
-			    "a valid size specifier!\n", pszParmValue));
+			DEBUG(0, ("set_variable(%s): value is not "
+			          "a valid size specifier!\n", pszParmValue));
 			return false;
 		}
 
-- 
1.7.9.5


From ca10e06796c866031cc1bdf002ea9ffca6a77fd2 Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Mon, 29 Oct 2012 15:16:04 +0100
Subject: [PATCH 3/3] lib/param: fix line length of DEBUG statments touched in
 previous commit in set_variable()

Signed-off-by: Michael Adam <obnox at samba.org>
---
 lib/param/loadparm.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c
index 66ff9a5..2462796 100644
--- a/lib/param/loadparm.c
+++ b/lib/param/loadparm.c
@@ -1300,7 +1300,8 @@ static bool set_variable(TALLOC_CTX *mem_ctx, int parmnum, void *parm_ptr,
 		case P_BOOL: {
 			bool b;
 			if (!set_boolean(pszParmValue, &b)) {
-				DEBUG(0,("set_variable(%s): value is not boolean!\n", pszParmValue));
+				DEBUG(0, ("set_variable(%s): value is not "
+					  "boolean!\n", pszParmValue));
 				return false;
 			}
 			*(bool *)parm_ptr = b;
@@ -1310,7 +1311,8 @@ static bool set_variable(TALLOC_CTX *mem_ctx, int parmnum, void *parm_ptr,
 		case P_BOOLREV: {
 			bool b;
 			if (!set_boolean(pszParmValue, &b)) {
-				DEBUG(0,("set_variable(%s): value is not boolean!\n", pszParmValue));
+				DEBUG(0, ("set_variable(%s): value is not "
+					  "boolean!\n", pszParmValue));
 				return false;
 			}
 			*(bool *)parm_ptr = !b;
-- 
1.7.9.5

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121029/d948e71b/attachment.pgp>