[PATCH] packaging: Add NetworkManager dispatcher script for winbind.

Andreas Schneider asn at cryptomilk.org
Sat Oct 27 11:00:32 MDT 2012


On Saturday 27 October 2012 09:43:02 simo wrote:
> On Sat, 2012-10-27 at 11:29 +0200, Andreas Schneider wrote:
> > On Friday 26 October 2012 12:02:23 Jelmer Vernooij wrote:
> > > This appears to be specific to systemd. Wouldn't it be better placed in
> > > packaging/systemd ?
> > 
> > It is a script for NetworkManager and not for systemd. I wouldn't put in
> > the the systemd directory.
> 
> Well the script uses systemd unconditionally.
> Maybe you should make it conditional ? (Check if systemd exist/is
> configured otherwise uses sys5 ?

I don't want to do that. With systemd it the same on each distribution using 
systemd.

If I add sysinit stuff, then it doesn't work on suse and we need another 
conditional. Then the  next person shows up and extends it to work with 
upstart and we end with several hundred lines of code for a simple task.

The rule is too keep it simple. If you want sysinitv support add another 
script. Document it in the README.


	-- andreas


-- 
Andreas Schneider                   GPG-ID: F33E3FC6
www.cryptomilk.org                asn at cryptomilk.org



More information about the samba-technical mailing list