[PATCH] Re: [Samba] SYSVOL ACLs and GPOs

Andrew Bartlett abartlet at samba.org
Fri Oct 26 18:32:01 MDT 2012


On Fri, 2012-10-26 at 19:02 -0400, simo wrote:
> On Sat, 2012-10-27 at 09:24 +1100, Andrew Bartlett wrote:
> > +                       } else if (errno == ERANGE && requested_len <
> > 49060) {
> > +                               requested_len += 4096; /* Just guess,
> > this isn't meant to happen! */ 
> 
> Why this arbitrary 49060 number ?

Looking at lib/replace/xattr.c:73 this patch is junk anyway.  

As Luiz is on FreeBSD, I just need to fix *that* code to pass the 0/NULL
probe down and return, rather than returning ERANGE.

I'm stumped as to how this ever worked, but a correct fix shouldn't be
too hard.

Luiz,

Do let me know if this helped however, it would be a useful data point. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list