[PATCH][WIP] Make vfs_acl_xattr use hash of the posix ACL

Christian Ambach ambi at samba.org
Fri Oct 26 16:10:38 MDT 2012

Hi Andrew,

On 10/24/2012 01:45 PM, Andrew Bartlett wrote:

> I've made some small changes, which are in fix-acls2.  What I need to do
> with you is hook up gpfs to the new non_posix_acls helper functions I've
> written.  (I decided against the change we discussed, to avoid needing
> to call stat at both layers).
> The blob you get from gpfs is the acl_as_blob argument.
> Anyway, we should probably do some of this interactively, let me know
> when you have time.

I was on vacation for the last two weeks. I'll try to catch you on IRC
early next week, until then I will already look at the code and see how
to fit the GPFS module (and others) to it.

One piece that might be worth revisting is the amount of ACL functions
we will then have in the VFS, e.g. the ones for getting an ACL:

NTSTATUS (*fget_nt_acl_fn)(struct vfs_handle_struct *handle,
NTSTATUS (*get_nt_acl_fn)(struct vfs_handle_struct *handle,
SMB_ACL_T (*sys_acl_get_file_fn)(struct vfs_handle_struct *handle,
SMB_ACL_T (*sys_acl_get_fd_fn)(struct vfs_handle_struct *handle,
int (*sys_acl_blob_get_file_fn)(struct vfs_handle_struct *handle,
int (*sys_acl_blob_get_fd_fn)(struct vfs_handle_struct *handle, struct
files_struct *fsp,

So anybody who wants to create a new module for ACL support for a
special platform will have to deal with having to implement lots of
functions, and some of them do really similar things and others just do
a subset of what another one does (e.g. sys_acl_get_file_fn might be a
subset of sys_acl_blob_get_file_fn).

Would it make sense to reduce the interface here (instead of growing it ?)


More information about the samba-technical mailing list