[PATCH][WIP] Make vfs_acl_xattr use hash of the posix ACL
abartlet at samba.org
Thu Oct 25 03:52:39 MDT 2012
On Wed, 2012-10-24 at 22:45 +1100, Andrew Bartlett wrote:
> On Tue, 2012-10-23 at 22:40 +0200, Christian Ambach wrote:
> > Hi Andrew,
> > On 10/23/2012 06:45 AM, Andrew Bartlett wrote:
> > > The scheme is really meant to be for arbitrary ACL schemes, and I've
> > > tried hard not to encode anything specific to one ACL scheme in it.
> > >
> > > I'll follow up with Christian's note however that all ACL types we have
> > > seen so far would benefit from the user/group/mode being added to the
> > > hash, so that will be put in common.
> > Please let me know when this is available in a kind of stable condition
> > in a branch accessible for me so I can look into making it work with
> > GPFS (as a guinea pig for the other file systems).
> I've made some small changes, which are in fix-acls2. What I need to do
> with you is hook up gpfs to the new non_posix_acls helper functions I've
> written. (I decided against the change we discussed, to avoid needing
> to call stat at both layers).
> The blob you get from gpfs is the acl_as_blob argument.
> Anyway, we should probably do some of this interactively, let me know
> when you have time.
> When this is all finished to your satisfaction, we can probably squash
> some patches as well.
In the meantime, I've finally written the tests I was interested in.
These now show that the NT ACL invalidation code works correctly, as
well as testing the mapping of posix ACLs that have never had an NT ACL
The only remaining extension I can think of is to ensure we cover the
version 3 attributes, along with the existing tests for version 1 (ntvfs
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
More information about the samba-technical