backup intent and dptr_create failure because of become_root() (was Re: Samba4 panic action)

[Jeremy Allison]

On Wed, Oct 24, 2012 at 04:55:37PM +1100, Andrew Bartlett wrote:
> On Sat, 2012-10-20 at 21:39 +1100, Andrew Bartlett wrote:
> 
> > Jeremy,
> > 
> > I think you can probably handle it from here.  We don't call
> > get_current_nttok() in many places, perhaps we might be able to replace
> > it with a call that doesn't need to inspect the unix security stack, but
> > instead directly de-references conn or something similar?
> 
> Jeremy,
> 
> This is to my eyes fairly clearly an issue with your new backup intent
> code.  Do you have the time to look into it?  Is that code in 4.0?

Yes, now I'm back I'll look into it. This code is in 4.0.0.
I assumed get_current_nttok() will always return a valid
nt token, never NULL - even when we're under a become_root()
call.

I'll log a bug against 4.0.x and fix.

Jeremy.