[PATCH] Re: samba4 RC3 RPC server process crashing!

[Andrew Bartlett]

On Wed, 2012-10-24 at 08:25 +1100, Andrew Bartlett wrote:
> On Tue, 2012-10-23 at 13:46 -0400, Greg Dickie wrote:
> > More info. Looks like replication. I got a core file:
> 
> Are you able to reproduce this under valgrind?
> 
> What's happened here is that our server-side application logic (almost
> certainly in the cracknames code) has left a structure only partially
> initialised.  Then we wander off the end of the wild pointer.
> 
> I'll look into the recent changes in this area, but valgrind would
> pinpoint it instantly. 

Thanks for the valgrind output (off-list).  This one is pretty simple,
we just didn't use talloc_zero().

However, what is more curious is how we got to give this error - this is
an odd routine, where then return value is almost always OK, but a
different value indicates the failures encountered.

Can you forward me (off-list) a level 10 debug log of the same thing
that gave the failure?

In any case, here is the patch for the intimidate issue. 

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dsdb-cracknames-Always-use-talloc_zero.patch
Type: text/x-patch
Size: 987 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121024/e90227fd/attachment.bin>