[PATCH] s3:smbd:durable: factor stat checks out into vfs_default_durable_reconnect_check_stat()

Michael Adam obnox at samba.org
Tue Oct 23 05:26:37 MDT 2012

Hi Jeremy,

here is the patch that factors the stat checks of the durable
reconnect function out into its own function.
I agree that it simplifies the code.

Metze has already reviewed it, but I would like to let you
have a look.

Cheers - Michael

PS: I am curious to see whether the patchwork thing picks
this patch up - it is created via git format-patch and then
attached to the mail.

On 2012-10-20 at 00:57 -0700, Jeremy Allison wrote:
> On Fri, Oct 19, 2012 at 09:03:46PM +0200, Michael Adam wrote:
> > On 2012-10-19 at 10:14 -0700, Jeremy Allison wrote:
> > > Can you guys split these checks out into a static function
> > > that you call once from vfs_default_durable_reconnect() ?
> > > 
> > > Putting these checks inside that function makes it a million
> > > lines long and hard to read :-).
> > 
> > /me goes counting lines and major culprits in various even longer
> > functions like open_file_ntcreate()... ;-)
> Yes I know. And I got beaten up so much for that I never
> did it again :-). And vl and I have been slimming it down
> ever since :-).
> > Seriously: Certainly, we can do that.
> > Do you mean a single function of each of the checks, or would
> > you be fine with one function for all the stat detail checks?
> One function for all of the stat checks works for me. That
> function just goes through a series of logical steps, to
> me it makes sense for it to be factored out into independent
> logical groups (i.e. the stat checks are one) that are put
> into separate static functions.
> Thanks !
> Jeremy.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-smbd-durable-factor-stat-checks-out-into-vfs_defa.patch
Type: text/x-patch
Size: 21975 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121023/171505ed/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121023/171505ed/attachment.pgp>

More information about the samba-technical mailing list