review tools (was Re: Code review required for commits - formal Team vote.)

[Günter Kukkukk]

Am Dienstag, 23. Oktober 2012, 00:26:53 schrieb simo:
> On Mon, 2012-10-22 at 23:51 +0200, Michael Adam wrote:
> > Hi Simo,
> > 
> > On 2012-10-22 at 13:22 -0400, simo wrote:
> > > Ok, I've set up an instance on my server.
> > > 
> > > Just go to http://patchwork.samba.org and you should be redirected to
> > > the proper site.

Simo, thanks for setting up some basic stuff,

but - even if the current "patchwork" setup might only be used
during a testing period for reviews - i think, it _must_ be
hosted by a "samba admin controlled" domain. (as usual..)

So, please no redirection.

Cheers,  Günter


> > 
> > Cool!
> > 
> > > I do not have a subdomain SSL cert, so you'll have to accept the
> > > security exception for now.
> > > 
> > > I am still playing a bit with the configuration so ping me if something
> > > doesn't work properly.
> > 
> > So, it tracks samba-technical at lists.samba.org.
> > 
> > What is the pattern that triggers patchwork to pick up a mail?
> > Simply [PATCH] in the subject?
> > If so, why was Scott Lovenberg's patch mail (that came after
> > David's) not picked up?
> 
> I pumped in Daivd's patch manually as a test, the system was not
> subscribed to the list yet when Scott's patch came in.
> 
> So there is one gotchs with patchwork. If you send multiple patches in
> the same mail message only the last one will be picked up.
> 
> Using git send-mail will send one patch per mail and make the whole
> process of tracking them easier
> I suggest people try to use it or anyway send a separate mail per patch.
> 
> Simo.