review tools (was Re: Code review required for commits - formal Team vote.)

simo idra at
Mon Oct 22 16:26:53 MDT 2012

On Mon, 2012-10-22 at 23:51 +0200, Michael Adam wrote:
> Hi Simo,
> On 2012-10-22 at 13:22 -0400, simo wrote:
> > 
> > Ok, I've set up an instance on my server.
> > 
> > Just go to and you should be redirected to
> > the proper site.
> Cool!
> > I do not have a subdomain SSL cert, so you'll have to accept the
> > security exception for now.
> > 
> > I am still playing a bit with the configuration so ping me if something
> > doesn't work properly.
> So, it tracks samba-technical at
> What is the pattern that triggers patchwork to pick up a mail?
> Simply [PATCH] in the subject?
> If so, why was Scott Lovenberg's patch mail (that came after
> David's) not picked up?

I pumped in Daivd's patch manually as a test, the system was not
subscribed to the list yet when Scott's patch came in.

So there is one gotchs with patchwork. If you send multiple patches in
the same mail message only the last one will be picked up.

Using git send-mail will send one patch per mail and make the whole
process of tracking them easier
I suggest people try to use it or anyway send a separate mail per patch.


Simo Sorce
Samba Team GPL Compliance Officer <simo at>
Principal Software Engineer at Red Hat, Inc. <simo at>

More information about the samba-technical mailing list