[PATCH REVIEW] fix brace placement for readability

Matthieu Patou mat at matws.net
Wed Oct 17 10:06:13 MDT 2012


I also like this rule even though i know it for only a couple of weeks.
Matthieu.

Michael Adam <obnox at samba.org> wrote:

On 2012-10-17 at 12:17 +0200, Kai Blin wrote:
> On 2012-10-17 12:14, Jeremy Allison wrote:
> > On Wed, Oct 17, 2012 at 12:10:58PM +0200, Michael Adam wrote:
> >> Hi,
> >> 
> >> when working on some code, I sometimes need to fix brace
> >> placements so I can better grasp the flow at one look. This
> >> particular thing is in our coding guidelines, even though it does
> >> not seem to be widely known. :)
> > 
> > Is this really in our coding guidelines ? I *hate* it :-).
> > 
> > Can you show me where it states this ? If so I'll push it :-).
> 
> README.Coding, line 224-225, with an example some lines below that.

Thanks for the reference!

I like it a lot, because it helps me see the start and end
of a block if the if- or loop-condition breaks across multiple
lines.

Thanks - Michael




More information about the samba-technical mailing list