[PATCH REVIEW] fix brace placement for readability

simo idra at samba.org
Wed Oct 17 06:44:56 MDT 2012


On Wed, 2012-10-17 at 03:14 -0700, Jeremy Allison wrote:
> On Wed, Oct 17, 2012 at 12:10:58PM +0200, Michael Adam wrote:
> > Hi,
> > 
> > when working on some code, I sometimes need
> > to fix brace placements so I can better grasp
> > the flow at one look. This particular thing
> > is in our coding guidelines, even though it
> > does not seem to be widely known. :)
> 
> Is this really in our coding guidelines ? I *hate* it :-).
> 
> Can you show me where it states this ? If so I'll push
> it :-).

I hate it too, I though braces on new line were allowed exclusively for
function declarations in our guideline.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>



More information about the samba-technical mailing list