Code review required for commits - formal Team vote.

Jeremy Allison jra at samba.org
Wed Oct 17 06:18:00 MDT 2012


On Wed, Oct 17, 2012 at 07:17:48AM -0400, Ira Cooper wrote:
> On Wed, Oct 17, 2012 at 3:07 AM, Jeremy Allison <jra at samba.org> wrote:
> > On Wed, Oct 17, 2012 at 01:00:58AM +0200, Michael Adam wrote:
> 
> >> - Do we need a tracking tool for reviews so patches don't get lost?
> >>   (this is roughly a.k.a how do I get a reviewer for my patch?)
> >
> > Right now I'm using my inbox. What would you suggest as
> > a different tool ? At work we use gerrit, but Simo has
> > some valid (Java cough, cough :-) reasons to avoid that :-).
> 
> Why is Java a valid reason?

I'll let Simo answer if he wants, but basically he objects
to them re-writing a git server rather than re-using the
existing one. Java is just the punchline to the joke :-).

Jeremy.


More information about the samba-technical mailing list