[PATCH REVIEW] fix brace placement for readability

[Michael Adam]

On 2012-10-17 at 03:44 -0700, Jeremy Allison wrote:
> On Wed, Oct 17, 2012 at 12:22:17PM +0200, Michael Adam wrote:
> > On 2012-10-17 at 12:17 +0200, Kai Blin wrote:
> > > On 2012-10-17 12:14, Jeremy Allison wrote:
> > > > On Wed, Oct 17, 2012 at 12:10:58PM +0200, Michael Adam wrote:
> > > >> Hi,
> > > >> 
> > > >> when working on some code, I sometimes need to fix brace
> > > >> placements so I can better grasp the flow at one look. This
> > > >> particular thing is in our coding guidelines, even though it does
> > > >> not seem to be widely known. :)
> > > > 
> > > > Is this really in our coding guidelines ? I *hate* it :-).
> > > > 
> > > > Can you show me where it states this ? If so I'll push it :-).
> > > 
> > > README.Coding, line 224-225, with an example some lines below that.
> > 
> > Thanks for the reference!
> 
> It's a fair cop :-). Ok I'll push.
> 
> > I like it a lot, because it helps me see the start and end
> > of a block if the if- or loop-condition breaks across multiple
> > lines.
> 
> Personally I find it very confusing, but if it's in
> the README.Coding.... :-(.

We could of course discuss this.
We have quite a good practice at discussing stuff atm... ;-)

Thanks for pushing - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121017/d70679c2/attachment.pgp>