[PATCH REVIEW] fix brace placement for readability
jra at samba.org
Wed Oct 17 04:44:57 MDT 2012
On Wed, Oct 17, 2012 at 12:22:17PM +0200, Michael Adam wrote:
> On 2012-10-17 at 12:17 +0200, Kai Blin wrote:
> > On 2012-10-17 12:14, Jeremy Allison wrote:
> > > On Wed, Oct 17, 2012 at 12:10:58PM +0200, Michael Adam wrote:
> > >> Hi,
> > >>
> > >> when working on some code, I sometimes need to fix brace
> > >> placements so I can better grasp the flow at one look. This
> > >> particular thing is in our coding guidelines, even though it does
> > >> not seem to be widely known. :)
> > >
> > > Is this really in our coding guidelines ? I *hate* it :-).
> > >
> > > Can you show me where it states this ? If so I'll push it :-).
> > README.Coding, line 224-225, with an example some lines below that.
> Thanks for the reference!
It's a fair cop :-). Ok I'll push.
> I like it a lot, because it helps me see the start and end
> of a block if the if- or loop-condition breaks across multiple
Personally I find it very confusing, but if it's in
the README.Coding.... :-(.
More information about the samba-technical