[PATCH] s3fs-auth: Use the correct name for the guest auth module.

Andreas Schneider asn at samba.org
Tue Oct 16 13:39:24 MDT 2012


On Tuesday 16 October 2012 21:00:29 you wrote:
> On 10/16/2012 02:09 PM, Andreas Schneider wrote:
> > The auth method name of this module is 'guest' and not 'builtin'.
> > 
> > Signed-off-by: Andreas Schneider <asn at samba.org>
> > ---
> > 
> >   source3/auth/{auth_builtin.c => auth_guest.c} | 0
> >   source3/auth/wscript_build                    | 9 ++++-----
> >   2 files changed, 4 insertions(+), 5 deletions(-)
> >   rename source3/auth/{auth_builtin.c => auth_guest.c} (100%)
> 
> Can you change this in the autoconf build please as well? Otherwise that
> one will break (not finding the file any more).

The patch isn't correct. I think we need to split the code or remove the 
builtin part or ...

I opened a bug too.

https://bugzilla.samba.org/show_bug.cgi?id=9295

I would fix it but I need some advice what we want. "builtin" is not 
documented in smb.conf.


	-- andreas

-- 
Andreas Schneider                   GPG-ID: F33E3FC6
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list