[PATCH] libcli/dns: Time out requests after a while

Matthieu Patou mat at samba.org
Tue Oct 16 12:09:50 MDT 2012

On 10/16/2012 02:08 AM, Jeremy Allison wrote:
> On Tue, Oct 16, 2012 at 11:00:41AM +0200, Kai Blin wrote:
>> Thanks. Note how it was easier to get the patch into the release branch
>> via bugzilla than it was to get it into master, and I had to whine to
>> get people to push it. And that's a single trivial patch that already is
>> in a release now.
> That's unfair. You posted the patch on the bug, got review and
> it got pushed as per bugzilla proceedure. I wouldn't call doing
> one ping on the list noting it'd already gone into 4.0.0rc having
> to "whine" to get it in. I was already tracking this patch (which
> is why it was still in my inbox) to ensure it got in.
> Note you didn't ask anyone in particular to review, just posted
> to the list. If you had explicitly sent to someone requesting
> review then I know (at least for me) it would have gotten in
> faster.
Yeah but that's tricky, I'm often wandering in DRS, ACL stuff.
So for DRS I think the reviewers are Metze, Andrew (I put tridge appart) 
so I'm down to 2 reviewers ? I know two peoples who gonna get bored quickly
And for ACL it's worth the clear expert is Nadya but she's quite busy 
with some other stuff so the review will be delayed and I can ask you 
but it's DS related ACLs which are a different beast than the FS ACLs.

If one those two subjects I ask other people I don't think I'll have a 
lot of feedback.
> As soon as you raised this on the list (even without asking
> a perticular person) it got pushed. I don't think that's too
> bad IMHO.
> Note I have an outstanding patch also waiting a push - but
> this is because I explicitly requested vl to look at it and
> he and I are still discussing this in private email.
Shouldn't review be public ?


Matthieu Patou
Samba Team

More information about the samba-technical mailing list