Review process

Matthieu Patou mat at
Tue Oct 16 12:03:29 MDT 2012

On 10/16/2012 02:53 AM, Kai Blin wrote:
> On 2012-10-16 11:08, Jeremy Allison wrote:
>> That's unfair. You posted the patch on the bug, got review and
>> it got pushed as per bugzilla proceedure. I wouldn't call doing
>> one ping on the list noting it'd already gone into 4.0.0rc having
>> to "whine" to get it in. I was already tracking this patch (which
>> is why it was still in my inbox) to ensure it got in.
> Fair enough, I was overdramatizing a bit on the "whining" part. However,
> I was a bit miffed that a patch that I'd have had in master since Sunday
> was actually overtaken by the same patch to a bugfix release, which
> you'd expect to be the slower process.
> I only do my famous mind-reading trick on Thursdays, so I couldn't tell
> somebody was already tracking the patch.
>> Note you didn't ask anyone in particular to review, just posted
>> to the list. If you had explicitly sent to someone requesting
>> review then I know (at least for me) it would have gotten in
>> faster.
> Note that I did CC Matthieu on the first patch and Volker on the second.
> I'm sending patches straight from my git tree using "git-format-patch |
> git send-email", so the email text is actually the commit message.
> Apparently that's not the correct way to do this.
Sorry I didn't react very quickly on this, I have a limited bandwidth 
and yes I found it more fun to work on having 2012 dcpromo in a S4 
domain, but it was in my list.


Matthieu Patou
Samba Team

More information about the samba-technical mailing list