[PATCH] libcli/dns: Time out requests after a while

Jeremy Allison jra at samba.org
Tue Oct 16 03:08:42 MDT 2012

On Tue, Oct 16, 2012 at 11:00:41AM +0200, Kai Blin wrote:
> Thanks. Note how it was easier to get the patch into the release branch
> via bugzilla than it was to get it into master, and I had to whine to
> get people to push it. And that's a single trivial patch that already is
> in a release now.

That's unfair. You posted the patch on the bug, got review and
it got pushed as per bugzilla proceedure. I wouldn't call doing
one ping on the list noting it'd already gone into 4.0.0rc having
to "whine" to get it in. I was already tracking this patch (which
is why it was still in my inbox) to ensure it got in.

Note you didn't ask anyone in particular to review, just posted
to the list. If you had explicitly sent to someone requesting
review then I know (at least for me) it would have gotten in

As soon as you raised this on the list (even without asking
a perticular person) it got pushed. I don't think that's too
bad IMHO.

Note I have an outstanding patch also waiting a push - but
this is because I explicitly requested vl to look at it and
he and I are still discussing this in private email.


More information about the samba-technical mailing list