Code review required for commits - formal Team vote.

Christian Ambach ambi at
Sat Oct 13 05:28:22 MDT 2012

On 10/12/2012 07:48 PM, Jeremy Allison wrote:

> --------------------------------------------------------
> No team member commits their own code.  All code will be "signed off"
> by two team members, as a team member you may sign off your own code.
> The "non-author" team member will be responsible for pushing the code.
> If there are two they can agree among themselves.
> Tools for code review to be decided amongst reviewers, but any
> patch posted to samba-technical is an explicit request for review.
> Release branches work as they do today, though the + should be treated
> as a sign-off in bugzilla. All release branch bug commits must contain
> their bug number in them, so we can track back what happened.
> --------------------------------------------------------

In principle, I would vote +1 for this proposal.

But I can also understand some of the reservations that others have, 
especially if it comes to patches to areas of the code that are not 
under regular development near to being un-maintained at all.
It will be difficult to find a second reviewer for this.

Other areas might be special VFS modules that are made for certain 
client applications (like catia, mediaharmony) or uncommon platforms 
(e.g. OpenAFS).

So I'll put my vote on hold until the concerns have been resolved.


More information about the samba-technical mailing list