Code review required for commits - formal Team vote.

Volker Lendecke Volker.Lendecke at SerNet.DE
Sat Oct 13 03:02:29 MDT 2012


On Fri, Oct 12, 2012 at 10:48:32AM -0700, Jeremy Allison wrote:
> --------------------------------------------------------
> No team member commits their own code.  All code will be "signed off"
> by two team members, as a team member you may sign off your own code.
> The "non-author" team member will be responsible for pushing the code.
> If there are two they can agree among themselves.
> 
> Tools for code review to be decided amongst reviewers, but any
> patch posted to samba-technical is an explicit request for review.
> 
> Release branches work as they do today, though the + should be treated
> as a sign-off in bugzilla. All release branch bug commits must contain
> their bug number in them, so we can track back what happened.
> --------------------------------------------------------

+1

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list