Code review required for commits - formal Team vote.

Jeremy Allison jra at
Fri Oct 12 17:20:38 MDT 2012

On Sat, Oct 13, 2012 at 01:13:05AM +0200, Michael Adam wrote:
> my vote: +1
> question:
> what kind of vote is this intended to be?
> unanimous? majority? ...

Majority was my intent.

> comments:
> * I don't yet understand the reasons for "-1"s
> * it makes no sense to require review but add a free pass after a
>   timeout
> * Productivity need not drop when not pushing ones own
>   patches, because one can work on a private branch until
>   patches hit master.



More information about the samba-technical mailing list