Code review required for commits - formal Team vote.

Andrew Bartlett abartlet at samba.org
Fri Oct 12 14:41:03 MDT 2012


On Fri, 2012-10-12 at 10:48 -0700, Jeremy Allison wrote:
> Ok, I'd like to bring this to a conclusion before I have to go
> on my European trip next week :-).
> 
> Sorry for asking for another vote after people have already
> +1 and -1'ed, but there have been so many discussions about
> what exactly the details of the policy should be that I think
> it might be useful to re-iterate exactly what we're voting on.
> 
> Just to be clear - the formal proposal, originally from
> Ira (but slightly tweaked by me after the discussions)
> is here:
> 
> --------------------------------------------------------
> No team member commits their own code.  All code will be "signed off"
> by two team members, as a team member you may sign off your own code.
> The "non-author" team member will be responsible for pushing the code.
> If there are two they can agree among themselves.
> 
> Tools for code review to be decided amongst reviewers, but any
> patch posted to samba-technical is an explicit request for review.
> 
> Release branches work as they do today, though the + should be treated
> as a sign-off in bugzilla. All release branch bug commits must contain
> their bug number in them, so we can track back what happened.
> --------------------------------------------------------

As I've tried to explain multiple times:

-1

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list