Code review required for commits - Discuss.

Jeremy Allison jra at
Fri Oct 12 11:25:56 MDT 2012

On Fri, Oct 12, 2012 at 11:31:38AM +0200, Kai Blin wrote:
> Hash: SHA1
> On 2012-10-12 10:20, Volker Lendecke wrote:
> > Just be a PITA for the reviewers. Send mails, call them, start to
> > use other means like hop on a train to Goettingen with a LART tool
> > :-)
> That's a reasonable effort for people who work on Samba on their
> dayjob. I've got to take at least one day off at work to get to
> Göttingen. On the worst case scenario, that limits me to 30 patchsets
> a year, assuming I spend all my vacation getting patches in. ;)
> I'm still worried that this system is going to leak patches,
> especially if we don't allow for pushes after patches were ignored for
> a while.
> I think if we go towards a required review system, we really, really
> need to make sure we don't drop patches.

Yes. This is a requirement.

But not a blocker for implementation. If patches are getting
dropped then patch authors will complain.

We can revisit this and change policy if things don't seem
to be working. It's not set in stone.


More information about the samba-technical mailing list