Code review required for commits - Discuss.

Jeremy Allison jra at samba.org
Fri Oct 12 10:32:18 MDT 2012


On Fri, Oct 12, 2012 at 08:40:59AM +0200, Michael Adam wrote:
> 
> But for master, this might become different, we frequently have
> a patch in master before we create the corresponding bug report
> for a release... Are you usuggesting that we should change that
> to require creating but reports and changing commit messages
> for the master branch as part of the review process before pushing?
> 
> To my opinion, it would be important to require the bug number in
> subject requirement for the stable release branches, and have it
> as a best effort thing for master just as we do now.

+1 - that's pretty much what I meant by "require bug number" -
that's for stable releases only.


More information about the samba-technical mailing list