[PATCH][WIP] Make vfs_acl_xattr use hash of the posix ACL

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Oct 12 09:12:27 MDT 2012


On Fri, Oct 12, 2012 at 10:26:15PM +1100, Andrew Bartlett wrote:
> On Fri, 2012-10-12 at 13:11 +0200, Christian Ambach wrote:
> > Hi Andrew,
> > 
> > On 10/09/2012 01:58 PM, Andrew Bartlett wrote:
> > > This patch (still a work in progress, as I know it fails some tests)
> > > is what I've been talking about for months, and which I got VFS
> > > changes in (almost - one small change in this patch) into 4.0.0rc1.
> > >
> > > The idea is simple, have the ACL modules (the posix ACL modules in
> > > particular) provide a blob form of the ACL, and then hash that,
> > > rather than an NT ACL that might change if our ACL mapping code
> > > changes.
> > 
> > I am not sure I am getting the problem you are trying to solve here.
> > What is the benefit of adding another representation of an ACL that is
> > just intermediate?
> > 
> > Can you give some more explanations that go further than the commit
> > message in your attachment?
> 
> This goes back to a discussion that we have had on and off over a few
> months.
> 
> What I'm working on is an improved implementation of the hash in
> vfs_acl_common.c.  The new hash will be of the 'system' ACL, whatever
> that is, rather than the NT ACL it maps to.

Why is hashing the NT ACL not sufficient here?

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list