Code review required for commits - Discuss.

Jeremy Allison jra at
Thu Oct 11 15:16:54 MDT 2012

On Thu, Oct 11, 2012 at 02:11:42PM -0700, Matthieu Patou wrote:
> I mean I don't care too much because I don't think I'll receive a
> lot of reviews but maybe should I ?

Yep, you should :-).

> I still prefer a clear rule that will put some social pressure on
> the reviewer and also give a kind of grant to the author of when
> this will land in master.

Ok - propose a rule ! What do you think would work ?

> Still in order to let people get familiar with this we can start on
> a voluntary basis rather than "now it has to be like that" (even if
> we don't have tools to enforce it).

Sounds good to me.


More information about the samba-technical mailing list