Code review required for commits - Discuss.

David Disseldorp ddiss at
Thu Oct 11 14:30:12 MDT 2012

On Thu, 11 Oct 2012 15:48:53 -0400
Ira Cooper <ira at> wrote:

> Actual formal suggestion:
> No team member commits their own code.  All code will be "signed off"
> by two team members, as a team member you may sign off your own code.
> The "non-author" team member will be responsible for pushing the code.
>  If there are two they can agree among themselves. ;)
> Release branches work as they do today, though the + should be treated
> as a sign-off in bugzilla.  All bug commits should now contain their
> bug number in them, so we can track back what happened.

+1 from me.

I'd also like to see reviews done in public. E.g. Author does a
git send-email to samba-technical, reviewer responds inline to each

Cheers, David

More information about the samba-technical mailing list