returning values on talloc_tos() (was Re: [PATCH][WIP] Make vfs_acl_xattr use hash of the posix ACL)

Jeremy Allison jra at
Wed Oct 10 21:22:13 MDT 2012

On Thu, Oct 11, 2012 at 11:27:56AM +1100, Andrew Bartlett wrote:
> Given that we memory we specifically return is allocated on the supplied
> context, what assumptions are you thinking of?

The kind of assumptions that lead me to commit this :


which might have ended up crashing the server
given the right RPC call.

> I'll find and fix these two (already removed another one of those) - the
> memory context is specified - as frame, the last parameter - it doesn't
> need the talloc_steal!

Oh cool, I missed that ! Thanks :-).

> As I think I've addressed all the issues raised by you and Simo, I
> propose to autobuild everything except the vfs_acl_common changes soon.
> (I still need to add fix and add tests for actual use of the new hash
> code).

Won't have time to read that until tomorrow (late here) but
as I said there were no show-stoppers for me.



More information about the samba-technical mailing list