returning values on talloc_tos() (was Re: [PATCH][WIP] Make vfs_acl_xattr use hash of the posix ACL)

Andrew Bartlett abartlet at samba.org
Wed Oct 10 02:37:56 MDT 2012


On Wed, 2012-10-10 at 08:37 +0200, Volker Lendecke wrote:
> On Tue, Oct 09, 2012 at 02:41:04PM -0700, Jeremy Allison wrote:
> > On Wed, Oct 10, 2012 at 07:50:03AM +1100, Andrew Bartlett wrote:
> > Right now we only have 3 VFS calls that take an explicit
> > context. I'm not sure adding context to the ACL calls
> > is the right move here. It's doable, but I'd like more
> > input before we decide.
> > 
> > Richard, Volker or Metze, can you comment ? You've
> > guys have probably written more VFS modules than anyone
> > else.
> > 
> > Explicit context for [F]GET_NT_ACL() calls or talloc_tos() ?
> 
> Explicit context please.

Thanks Volker.  I've prepared the attached two patches to do this.

I'm testing these and a broken-up set of patches for my other changes
now.  For the curious, the whole series is at
https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/fix-acls2

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-smbd-Add-mem_ctx-to-sys_acl_init-and-all-callers.patch
Type: text/x-patch
Size: 44547 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121010/242a405f/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-smbd-Add-mem_ctx-to-f-get_nt_acl-VFS-call.patch
Type: text/x-patch
Size: 46100 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121010/242a405f/attachment-0003.bin>


More information about the samba-technical mailing list