[PATCH 05/12] build: Removed unused functions with conflicting names from s3 torture

Andrew Bartlett abartlet at samba.org
Tue Oct 9 15:32:04 MDT 2012


On Tue, 2012-10-09 at 22:59 +0200, Andrzej Hajda wrote:
> Signed-off-by: Andrzej Hajda <andrzej.hajda at wp.pl>
> ---
>  source3/torture/test_idmap_tdb_common.c |   15 ---------------
>  1 file changed, 15 deletions(-)
> 
> diff --git a/source3/torture/test_idmap_tdb_common.c b/source3/torture/test_idmap_tdb_common.c
> index d081660..e34a3ad 100644
> --- a/source3/torture/test_idmap_tdb_common.c
> +++ b/source3/torture/test_idmap_tdb_common.c
> @@ -57,21 +57,6 @@ bool winbindd_use_idmap_cache(void) {
>  	return false;
>  }
>  
> -bool idmap_is_online(void)
> -{
> -	return true;
> -}
> -
> -NTSTATUS idmap_backends_sid_to_unixid(const char *domain, struct id_map *id)
> -{
> -	return NT_STATUS_OK;
> -}
> -
> -NTSTATUS idmap_backends_unixid_to_sid(const char *domname, struct id_map *id)
> -{
> -	return NT_STATUS_OK;
> -}
> -
>  static bool open_db(struct idmap_tdb_common_context *ctx)
>  {
>  	NTSTATUS status;

Are you sure these are unused?

Does 'make test' pass after these are removed?  The idmap modules (which
you removed by disabling all shared modules) are underlinked, and need
these functions at load time/runtime. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list