New talloc feature: memlimits
idra at samba.org
Fri Oct 5 08:47:25 MDT 2012
On Fri, 2012-10-05 at 10:12 -0400, simo wrote:
> On Fri, 2012-10-05 at 15:36 +0200, David Disseldorp wrote:
> > Hi Simo,
> > On Sat, 29 Sep 2012 00:45:20 -0400
> > simo <idra at samba.org> wrote:
> > > You can find it here:
> > > https://git.samba.org/idra/samba.git/?p=idra/samba.git;a=shortlog;h=refs/heads/talloc_memlimit
> > Could you please avoid the nested returns in the TALLOC_MEMLIMIT_*
> > macros? As discussed previously, macros that affect control flow break
> > the internal parsers of those who read the code.
> > Cheers, David
> > 1) http://lists.samba.org/archive/samba-technical/2012-May/084115.html
> Ah that is a good point, sorry for doing that myself.
> Expect a fix soon.
Ok I have a patch in autobuild to turn the macros into static functions
and stop returning implicitly.
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
More information about the samba-technical