Proposal to remove confusing "security XX mask" parameters for 4.0.0

[Andrew Bartlett]

On Wed, 2012-10-03 at 17:00 -0700, Jeremy Allison wrote:
> On Tue, Oct 02, 2012 at 09:41:01PM -0700, Jeremy Allison wrote:
> > 
> > What I'd like to propose is that we
> > remove the first 4 parameters:
> > 
> > security mask
> > force security mode
> > directory security mask
> > force directory security mode
> > 
> > for 4.0.0, and leave only the original
> > 
> > create mask
> > force create mode
> > directory mask
> > force directory mode
> > 
> > parameters, which will then be applied
> > on both create and ACL set operations.
> > 
> > This will simplify things quite a bit.
> 
> And here's the patch for 4.0.0rc3, currently
> testing.

I think this is missing the removal of the set_() functions from
source3/param, as it fails to build for me with:

../source3/param/loadparm.c: In function ‘lp_set_security_mask’:
../source3/param/loadparm.c:5478:29: error: ‘struct loadparm_service’
has no member named ‘iSecurity_mask’
../source3/param/loadparm.c:5479:19: error: ‘struct loadparm_service’
has no member named ‘iSecurity_mask’
../source3/param/loadparm.c: In function
‘lp_set_directory_security_mask’:
../source3/param/loadparm.c:5485:29: error: ‘struct loadparm_service’
has no member named ‘iDir_Security_mask’
../source3/param/loadparm.c:5486:19: error: ‘struct loadparm_service’
has no member named ‘iDir_Security_mask’

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org