[patch] cifs: proper fix for integer overflow in parse_dacl()

Dan Carpenter dan.carpenter at oracle.com
Wed Oct 3 06:43:39 MDT 2012

On Thu, Sep 27, 2012 at 11:49:08PM +0300, Dan Carpenter wrote:
> I tried to fix this before by adding the ULONG_MAX check, but num_aces
> is an unsigned int so it should have been UINT_MAX.  Sorry for that.
> These days we can just call kmalloc_array() which has the overflow check
> built in.

Uh...  It turns out that I still suck at understanding C.  My first
patch was fine.  Sorry for the noise.

dan carpenter

More information about the samba-technical mailing list