s3: Fix libnss_winbind.so's build on Illumos/Solaris

[Ira Cooper]

On Sun, Sep 30, 2012 at 6:52 PM, Andrew Bartlett <abartlet at samba.org> wrote:
> On Sun, 2012-09-30 at 22:57 +0200, Ira Cooper wrote:
>> The branch, master has been updated
>>        via  6dbe0aa s3: Fix libnss_winbind.so's build on Illumos/Solaris
>>       from  8180522 s4 dns: Fix return code for deleted records
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
>> commit 6dbe0aad260d1f6e46e58871a7ce613ca27d0bf6
>> Author: Ira Cooper <ira at samba.org>
>> Date:   Sun Sep 30 19:02:13 2012 +0000
>>
>>     s3: Fix libnss_winbind.so's build on Illumos/Solaris
>>
>>     Due to not building and linking in the winbind_nss_solaris bits in addition
>>     to the linux bits, nss was broken on Solaris.
>>
>>     Autobuild-User(master): Ira Cooper <ira at samba.org>
>>     Autobuild-Date(master): Sun Sep 30 22:56:30 CEST 2012 on sn-devel-104
>
> Ira,
>
> Thanks for taking a stab at fixing the build of nss_winbindd.
>
> Is there any chance you could finish the task following the pattern at
> source3/configure.in:5775?
>
> At a first glance it seems to me that with your change we might have
> lost support for non-Linux GNU systems and HP-UX, and we need to add in
> support for the remaining diversity.

Andrew,

I don't think there was a loss of support, from before my commit to
after it, I believe I merely made what was a nasty to track down
issue, explicit.  I'd gladly accept the review of the community on
this issue, and if revision is required, let us as a community get it
done.

Tracking down this issue literally cost me about 1/2 a day at SDC.  It
is nasty because you see the library load in truss... then you don't
see the winbind socket get connected to and you wonder "WTF just
happened."  Rebuild, etc... Literally I had to rebuild with autoconf,
and look at the Makefile to figure it out.

So I'd really like people with access to the needed platforms to work
this issue.  I don't feel confident fixing it "blindly." (Without
access to the needed platforms)

I have filed a bug in bugzilla: #9232
https://bugzilla.samba.org/show_bug.cgi?id=9232 with a patch to work
from on this issue for 4.0.  I hope that the team can get this issue
closed in an orderly manner.

If you have code, a list of impacted platforms, or anything else to
contribute to the effort, I look forward to seeing it in the bug.

Thanks,

-Ira