[PATCH 3/3] cifs: Enable Kconfig control of CIFS_DEBUG
joe at perches.com
Fri Nov 30 07:57:40 MST 2012
On Fri, 2012-11-30 at 06:56 -0500, Jeff Layton wrote:
> On Thu, 29 Nov 2012 11:37:20 -0800
> Joe Perches <joe at perches.com> wrote:
> > Rather than havign a permanently enabled #define, allow
> > control over it.
> > This can reduce the size of the module by ~100KB which
> > could be useful for embedded systems.
> > diff --git a/fs/cifs/cifs_debug.h b/fs/cifs/cifs_debug.h
> > index 4d12fe4..6867a7f 100644
> > --- a/fs/cifs/cifs_debug.h
> > +++ b/fs/cifs/cifs_debug.h
> > @@ -18,7 +18,10 @@
> > * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> > *
> > */
> > -#define CIFS_DEBUG /* BB temporary */
> > +
> > +#ifdef CONFIG_CIFS_DEBUG
> > +#define CIFS_DEBUG
> > +#endif
> > #ifndef _H_CIFS_DEBUG
> > #define _H_CIFS_DEBUG
> Looks fine, but I'd probably prefer to just get rid of CIFS_DEBUG
> altogether here and replace it with CONFIG_CIFS_DEBUG.
I wasn't sure if there was other code anywhere else that depends
on CIFS_DEBUG. There isn't any in the kernel source tree. If not,
then you are right, it should be just CONFIG_CIFS_DEBUG.
> While you're at it, /proc/fs/cifs/cifsFYI should probably not be
> present when CONFIG_CIFS_DEBUG isn't set. Perhaps we should also
> disable traceSMB and its related functions too in that case?
That could be considered a kernel api change.
If people agree to delete it, I'd be OK with it.
More information about the samba-technical