[PATCH 2/3] cifs: Make CIFS_DEBUG possible to undefine

Joe Perches joe at perches.com
Fri Nov 30 07:52:09 MST 2012

On Fri, 2012-11-30 at 06:49 -0500, Jeff Layton wrote:
> On Thu, 29 Nov 2012 11:37:19 -0800
> Joe Perches <joe at perches.com> wrote:
> > Make the compilation work again when CIFS_DEBUG is not #define'd.
> > 
> > Add format and argument verification for the various macros when
> > CIFS_DEBUG is not #define'd.
> Would it be better to simply make those the standard
> "do { ; } while(0)" noop macros?
> I'm not sure I see the point in keeping the printk statements in there...

Actually, that's not standard.
Look at printk.h

It prevents developers from adding code that compiles
without warnings in one mode but compiles with warnings
in another.

The idea is to make sure that format and arguments always
match regardless of whether or not you are compiling
debug or non-debug.

More information about the samba-technical mailing list