Bugzilla workflow with review

David Disseldorp ddiss at suse.de
Thu Nov 29 05:04:35 MST 2012


On Thu, 29 Nov 2012 11:51:27 +0100
Andreas Schneider <asn at samba.org> wrote:

> I don't see why we need to add a patch for each branch we can't cherry pick. 
> It is more work for us and also for Karolin. I'm sure she finds it easier to 
> just call 'git cherry-pick <sha1>' instead of downloading each patch.
> 
> So in most cases there should be only one patch in the bug. The one the 
> reviewer needs to push to master after a successful review.

I wasn't aware this was the current policy. Anyhow, I agree, it doesn't
make sense to attach multiple patches if the same can be cleanly applied
across multiple branches or cherry-picked.

As long as it is made completely clear in the bug which branches are the
intended target for a commit/patch, and Karolin is satisfied.

Cheers, David


More information about the samba-technical mailing list