[PATCH 00/16] Get rid of obsolete system getpass().

Jelmer Vernooij jelmer at samba.org
Fri Nov 23 11:22:18 MST 2012


On Fri, Nov 23, 2012 at 04:41:04PM +0100, Andreas Schneider wrote:
> The following patchset introduces a new function named samba_getpass so we can
> get rid of the deprecated system getpass() function and the implementation
> in libreplace. This way there should be no libreplace on Linux at all.
Thanks! This looks good, I'll land.

As mentioned on IRC, I think it would make sense to have
samba_getpass() return a talloc-ed string, rather than write to a
static buffer with specific size. This change is definitely an
improvement over the previous situation though, so let's land it.

Cheers,

Jelmer


More information about the samba-technical mailing list