[PATCH] Build fixes and align binary names and installed binary lists between waf and autoconf
Andreas Schneider
asn at samba.org
Thu Nov 22 06:55:28 MST 2012
On Thursday 22 November 2012 10:00:03 Andreas Schneider wrote:
> On Wednesday 21 November 2012 20:45:31 Andrew Bartlett wrote:
> > On Wed, 2012-11-21 at 20:34 +1100, Andrew Bartlett wrote:
> > > The rationale for each patch is in the comment, but overall this series
> > > of patches tries to fix up issues I noticed while doing some Debian
> > > packaging.
> > >
> > > In particular, it fixes up the last binary names that differ between the
> > > build systems, and will allow us to remove the 'binary mapping' system
> > > in make test eventually (once we are sure we don't need to rename
> > > again). Removing the autoconf locktest and masktest is part of that.
> > >
> > > This also removes the install flag from all our testing binaries, which
> > > should not be installed on the system or shipped by distributions. I
> > > note in particular that Debian ignores this in autoconf, and picks the
> > > binaries out of the build tree. This isn't practical with waf, and I
> > > hope we can agree not to package these (otherwise, debian can remove the
> > > install=False flag in a patch).
> > >
> > > Please review and build if acceptable.
> > >
> > > Thanks,
> > >
> > > Andrew Bartlett
> >
> > https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=shor
> > tl og;h=refs/heads/build-fixes has these in a git tree. I also fixed a
> > typo in the last patch, so I've re-attached.
>
> I will review it today. I will not include the getpass() patch. See other
> thread about getpass().
>
They are fine. I've pushed them to autobuild and opened a bug for 4.0:
https://bugzilla.samba.org/show_bug.cgi?id=9421
-- andreas
--
Andreas Schneider GPG-ID: F33E3FC6
Samba Team asn at samba.org
www.samba.org
More information about the samba-technical
mailing list