[PATCH 0/3] Fix master to pass smbtorture smb2.acls and raw.acls tests - v2 - with Simo fixes.
obnox at samba.org
Mon Nov 19 16:15:15 MST 2012
For a start, I pushed the first two patches to autobuild.
The change to the smb2.acls test, I have not yet quite
understood, especially since that code path is not
run at all in any tests I see. We should re-discuss this one.
Cheers - Michael
On 2012-11-16 at 10:54 +0100, Michael Adam wrote:
> Note: I have these in my local branch and am reviewing.
> Cheers - Michael
> On 2012-11-14 at 14:40 -0800, Jeremy Allison wrote:
> > NB! This patchset requires the patch already posted to samba-technical:
> > [PATCH] Another fix needed for bug #9236 - ACL masks incorrectly applied when setting ACLs.
> > to be applied first.
> > On top of that change, this patchset allows master to pass the smbtorture
> > smb2.acls and raw.acls tests correctly, with vfs_acl_xattr used on a share
> > definition.
> > Jeremy Allison (3):
> > Add comments explaining exactly *why* we don't check
> > FILE_READ_ATTRIBUTES when evaluating file/directory ACE's.
> > More for #9374 - Allow smb2.acls torture test to pass against smbd
> > with a POSIX ACLs backend.
> > Make smb2.acls test match the raw.acls test when running against
> > -Tsamba4 in that it expects the default Samba4 ACL, not the
> > Windows one.
> > source3/include/proto.h | 3 +--
> > source3/smbd/dir.c | 14 +++++++++-----
> > source3/smbd/file_access.c | 3 +--
> > source3/smbd/open.c | 24 +++++++++++++++++++++---
> > source4/torture/smb2/acls.c | 41 +++++++++++++++++++++++++++++++++++------
> > 5 files changed, 67 insertions(+), 18 deletions(-)
> > --
> > 184.108.40.206
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 206 bytes
Desc: not available
More information about the samba-technical